Fix: Prevent filter textbox from being cleared when folder is loaded - #18809
Open
Rana-Shumail wants to merge 1 commit into
Open
Fix: Prevent filter textbox from being cleared when folder is loaded#18809Rana-Shumail wants to merge 1 commit into
Rana-Shumail wants to merge 1 commit into
Conversation
…load This PR fixes an issue where the filter textbox is cleared 1-2 seconds after a folder loads if the user starts typing immediately. Root cause: The desktopIniUpdateTask runs with Low priority and clears the filter box after the UI thread goes idle. Any text typed by the user before this task executes is overwritten. Fix: Removed the delayed clearing. Instead, the filter is now cleared synchronously inside SetWorkingDirectoryAsync when the path actually changes (value != WorkingDirectory). Note: I wasn't able to compile the app locally due to a local toolchain issue, so this fix is based on code analysis. I'm happy to iterate if any feedback or issues arise during testing!
|
|
Josh65-2201
changed the title
Josh65-2201
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…load
This PR fixes an issue where the filter textbox is cleared 1-2 seconds after a folder loads if the user starts typing immediately.
Root cause: The desktopIniUpdateTask runs with Low priority and clears the filter box after the UI thread goes idle. Any text typed by the user before this task executes is overwritten.
Fix: Removed the delayed clearing. Instead, the filter is now cleared synchronously inside SetWorkingDirectoryAsync when the path actually changes (value != WorkingDirectory).
Note: I wasn't able to compile the app locally due to a local toolchain issue, so this fix is based on code analysis. I'm happy to iterate if any feedback or issues arise during testing!
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
ShellViewModel.csto trace the filter text binding.desktopIniUpdateTaskwas asynchronously clearingFilesAndFoldersFilteron a low-priority thread, which conflicted with immediate user typing.SetWorkingDirectoryAsynccorrectly resets the filter synchronously when navigating between folders.