[perf] scope slen to loop body to keep HIP photon loop flat - #267
Open
PrasoonMishra wants to merge 1 commit into
Open
[perf] scope slen to loop body to keep HIP photon loop flat#267PrasoonMishra wants to merge 1 commit into
PrasoonMishra wants to merge 1 commit into
Conversation
Declaring `slen` inside the loop body (instead of at function scope), just like it is in the OpenCL code, makes the port exactly the same. This is a very small change that should not have mattered, but it leads to a lot of optimization changes and degradation. We are looking into how to prevent such small things from hampering perf so drastically, but in the meantime this can be merged as it brings the HIP port to parity with the OpenCL port.
Author
|
Sample result:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaring
sleninside the loop body (instead of at function scope), just like it is in the OpenCL code, makes the port exactly the same. This is a very small change that should not have mattered, but it leads to optimization changes and degradation. We are looking into how to prevent such small things from hampering perf so drastically, but in the meantime, this can be merged as it brings the HIP port to parity with the OpenCL port.