Skip to content

chore: remove redundant CI steps - #91

Merged
itsoyou merged 3 commits into
mainfrom
syk/remove-dulpicated-lint
Aug 3, 2026
Merged

chore: remove redundant CI steps#91
itsoyou merged 3 commits into
mainfrom
syk/remove-dulpicated-lint

Conversation

@itsoyou

@itsoyou itsoyou commented Jul 22, 2026

Copy link
Copy Markdown
Member

@itsoyou
itsoyou requested a review from a team as a code owner July 22, 2026 14:15
Comment thread synapse_token_authenticator/token_authenticator.py
Comment thread synapse_token_authenticator/utils.py Outdated
Comment thread pyproject.toml
Comment thread tests/test_sta_utils.py Outdated
@itsoyou
itsoyou force-pushed the syk/remove-dulpicated-lint branch 3 times, most recently from c008f7f to 6040f80 Compare July 29, 2026 15:55
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.30769% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.05%. Comparing base (094a907) to head (3c65c3d).

Files with missing lines Patch % Lines
synapse_token_authenticator/config.py 34.00% 33 Missing ⚠️
synapse_token_authenticator/claims_validator.py 60.52% 9 Missing and 6 partials ⚠️
synapse_token_authenticator/token_authenticator.py 56.25% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   73.28%   72.05%   -1.23%     
==========================================
  Files           5        5              
  Lines         756      773      +17     
  Branches      145      144       -1     
==========================================
+ Hits          554      557       +3     
- Misses        143      157      +14     
  Partials       59       59              
Files with missing lines Coverage Δ
synapse_token_authenticator/utils.py 91.07% <100.00%> (+0.16%) ⬆️
synapse_token_authenticator/token_authenticator.py 71.53% <56.25%> (+0.07%) ⬆️
synapse_token_authenticator/claims_validator.py 75.96% <60.52%> (-1.64%) ⬇️
synapse_token_authenticator/config.py 64.97% <34.00%> (-3.85%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094a907...3c65c3d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jason-famedly jason-famedly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of little things a few questions. I think this is almost there!

Comment thread synapse_token_authenticator/claims_validator.py
Comment thread synapse_token_authenticator/claims_validator.py Outdated
Comment thread synapse_token_authenticator/token_authenticator.py Outdated
Comment thread synapse_token_authenticator/token_authenticator.py Outdated
Comment thread synapse_token_authenticator/token_authenticator.py Outdated
Comment thread synapse_token_authenticator/token_authenticator.py Outdated
Comment thread synapse_token_authenticator/utils.py
Comment thread pyproject.toml
@itsoyou
itsoyou requested a review from jason-famedly July 30, 2026 11:01
Comment thread synapse_token_authenticator/claims_validator.py Outdated
Comment thread synapse_token_authenticator/claims_validator.py Outdated
Comment thread tests/__init__.py
@itsoyou
itsoyou requested a review from jason-famedly July 30, 2026 14:04
Comment thread synapse_token_authenticator/claims_validator.py Outdated
@itsoyou
itsoyou force-pushed the syk/remove-dulpicated-lint branch from 2e47454 to 1da87e3 Compare August 3, 2026 10:47
@itsoyou
itsoyou requested a review from jason-famedly August 3, 2026 10:48
@itsoyou
itsoyou force-pushed the syk/remove-dulpicated-lint branch from 1da87e3 to 7ad79ad Compare August 3, 2026 11:56
@itsoyou
itsoyou force-pushed the syk/remove-dulpicated-lint branch from 7ad79ad to 3c65c3d Compare August 3, 2026 12:45

@jason-famedly jason-famedly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@itsoyou
itsoyou added this pull request to the merge queue Aug 3, 2026
Merged via the queue into main with commit 4380174 Aug 3, 2026
4 of 5 checks passed
@itsoyou
itsoyou deleted the syk/remove-dulpicated-lint branch August 3, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants