Add NTS cookie master-key loading and keystore selection - #577
Closed
sofiascalzo wants to merge 1 commit into
Closed
Add NTS cookie master-key loading and keystore selection#577sofiascalzo wants to merge 1 commit into
sofiascalzo wants to merge 1 commit into
Conversation
Summary: load the master key from a file and select the right keystore. - LoadMasterKeyFromFile reads the (Tupperware-materialized) master key verbatim, validates length, and fails closed on a read error or short key. - MasterKeyFingerprint returns a non-secret len + SHA-256[:4] identifier, safe to log, so KE/NTP can be confirmed to hold the same master. - NewKeystore selects DerivedKeystore when a master-key path is set (else the dev/test InMemoryKeystore), with an optional fingerprint assertion. Both server binaries build their keystore through it so they cannot diverge. Reviewed By: leoleovich Differential Revision: D114729858
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@sofiascalzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114729858. |
Contributor
|
This pull request has been merged in c957dca. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
load the master key from a file and select the right keystore.
verbatim, validates length, and fails closed on a read error or short key.
safe to log, so KE/NTP can be confirmed to hold the same master.
dev/test InMemoryKeystore), with an optional fingerprint assertion. Both
server binaries build their keystore through it so they cannot diverge.
Reviewed By: leoleovich
Differential Revision: D114729858