ntsketest: add slog.Debug [ntp] trace for the NTPv4 phase - #575
Closed
sofiascalzo wants to merge 1 commit into
Closed
ntsketest: add slog.Debug [ntp] trace for the NTPv4 phase#575sofiascalzo wants to merge 1 commit into
sofiascalzo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@sofiascalzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114046448. |
Summary: Emit per-step [ntp] traces (target resolved, request built, dialed, request sent, response received) via slog.Debug so the NTPv4 round-trip can be debugged, e.g. pinning down connection-refused failures to the resolved ntp addr. The default slog handler is set to debug level so the traces are visible. Also resolve the NTP target from the KE reply: prefer --ntp-addr, then the KE-advertised server/port (HandshakeResult.NTPServer/NTPPort), then <KE host>:123. Reviewed By: leoleovich Differential Revision: D114046448
sofiascalzo
force-pushed
the
export-D114046448
branch
from
August 5, 2026 10:28
332dcf3 to
442f6df
Compare
Contributor
|
This pull request has been merged in b8d86fc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Emit per-step [ntp] traces (target resolved, request built, dialed, request
sent, response received) via slog.Debug so the NTPv4 round-trip can be debugged,
e.g. pinning down connection-refused failures to the resolved ntp addr. The
default slog handler is set to debug level so the traces are visible.
Also resolve the NTP target from the KE reply: prefer --ntp-addr, then the
KE-advertised server/port (HandshakeResult.NTPServer/NTPPort), then :123.
Reviewed By: leoleovich
Differential Revision: D114046448