#83 Add optional per-query filter to WithIncludeQueryParameters#84
Open
nikolayk812 wants to merge 1 commit into
Open
#83 Add optional per-query filter to WithIncludeQueryParameters#84nikolayk812 wants to merge 1 commit into
nikolayk812 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithIncludeQueryParameters currently records all query parameters or none. This adds an optional filter function so you can skip recording parameters for specific queries (e.g. those touching sensitive tables like users or
payments).
Since pgx uses positional parameters ($1, $2, …) with no named arg support, per-argument redaction isn't practical — per-query is the right granularity.
Usage:
Fully backwards compatible — existing WithIncludeQueryParameters() calls with no filter are unchanged.