Skip to content

✨ app: support exa token on base#1150

Open
dieguezguille wants to merge 3 commits into
mainfrom
fixes-base
Open

✨ app: support exa token on base#1150
dieguezguille wants to merge 3 commits into
mainfrom
fixes-base

Conversation

@dieguezguille

@dieguezguille dieguezguille commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added EXA token support on Base.
    • Added swap support involving EXA on Base.
    • Implemented chain-aware EXA token discovery and balance handling across supported networks.
  • Bug Fixes
    • Improved token allowlisting and filtering per network (including deduping).
    • Prevented EXA from appearing when its deployment/address isn’t available, with graceful fallback behavior when token resolution fails.

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a240501

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7c69ea53-228b-4a77-8c99-15ab9805587b

📥 Commits

Reviewing files that changed from the base of the PR and between fbe082b and a240501.

📒 Files selected for processing (4)
  • .changeset/nice-moles-invent.md
  • .changeset/sour-items-strive.md
  • common/wagmi.config.ts
  • src/utils/lifi.ts

Walkthrough

Changes

EXA chain support

Layer / File(s) Summary
Optional EXA address wiring
common/wagmi.config.ts
Loads the optional EXA deployment and exposes its address through generated chain address exports.
Chain-aware LI.FI token flows
src/utils/lifi.ts
Uses the active chain and optional EXA address when fetching LI.FI tokens and balances, with case-insensitive deduplication and fallback behavior.
Per-chain allowlist and release metadata
src/utils/lifi.ts, .changeset/*
Stores allowlisted tokens by chain and records patch releases for EXA and Base swap support.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant LI.FI
  participant lifiTokensOptions
  participant generatedChain
  participant getToken
  LI.FI->>lifiTokensOptions: request tokens for chain.id
  lifiTokensOptions->>generatedChain: read exaAddress
  lifiTokensOptions->>getToken: fetch EXA for chain.id and exaAddress
  getToken-->>lifiTokensOptions: return chain-specific token
  lifiTokensOptions-->>LI.FI: return deduplicated token list
Loading

Possibly related PRs

  • exactly/exa#833: Both update EXA handling in src/utils/lifi.ts toward chain-aware token inclusion.
  • exactly/exa#1028: Both modify LI.FI token handling in src/utils/lifi.ts.

Suggested reviewers: franm91, cruzdanilo

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding EXA token support on Base.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes-base
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fixes-base

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for EXA and swaps on the Base network. It updates the wagmi configuration to load the EXA deployment and refactors the Li.Fi utility to dynamically use the EXA address instead of a hardcoded Optimism address, splitting the token allowlist by chain ID. The review feedback highlights two issues: a potential runtime TypeError in balancesOptions due to token.amount being a string instead of a bigint, and a case-sensitivity issue in the allowlist lookup because of a lowercase address entry.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/utils/lifi.ts
Comment thread src/utils/lifi.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88a062bba2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread common/wagmi.config.ts
Comment thread src/utils/lifi.ts Outdated
"0xFdb794692724153d1488CcdBE0C56c252596735F",
]),
[infra.base.id]: new Set([
"0x04C0599Ae5A44757c0af6F9eC3b93da8976c150A",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep base swap tokens on the deployed allowlist

For Base, this newly added allow list is not the same as the deployed ProposalManager allowlist: I checked contracts/broadcast/ProposalManager.s.sol/8453/run-latest.json, and 0x04C0599Ae5A44757c0af6F9eC3b93da8976c150A (plus several other added Base addresses) is absent from the constructor targets. When a user selects one of these tokens as an external source, ExaPlugin.swap first calls approve on that token through the account, and ProposalManager.preExecutionChecker rejects non-allowlisted targets, so the UI will quote and enable swaps that revert. Keep this list to the deployed ProposalManager targets or update the on-chain allowlist.

Useful? React with 👍 / 👎.

Comment thread src/utils/lifi.ts
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.28%. Comparing base (76a9dc4) to head (a240501).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/utils/lifi.ts 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
+ Coverage   73.27%   73.28%   +0.01%     
==========================================
  Files         254      254              
  Lines       10839    10844       +5     
  Branches     3598     3602       +4     
==========================================
+ Hits         7942     7947       +5     
+ Misses       2613     2611       -2     
- Partials      284      286       +2     
Flag Coverage Δ
e2e 72.63% <8.33%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ef68c5296

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/utils/lifi.ts

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9afca78b-58a0-4b1b-85b3-fbcf42a4bcb2

📥 Commits

Reviewing files that changed from the base of the PR and between 53ff381 and fbe082b.

📒 Files selected for processing (4)
  • .changeset/nice-moles-invent.md
  • .changeset/sour-items-strive.md
  • common/wagmi.config.ts
  • src/utils/lifi.ts

Comment thread src/utils/lifi.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant