Conversation
🦋 Changeset detectedLatest commit: 1369a37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1369a372ac
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| wallet_type: "self_custodied", // cspell:ignore custodied | ||
| wallet_attested_ownership_at: new Date().toISOString(), |
There was a problem hiding this comment.
Do not attest arbitrary source wallets as self-custodied
When users fund these instructions from an exchange or any other address, this template still sends wallet_type: "self_custodied" with a fresh attestation timestamp even though allow_any_from_address explicitly allows deposits regardless of from_address. Bridge's docs define self_custodied as customer-owned and require ownership validation before sending wallet_attested_ownership_at (https://apidocs.bridge.xyz/get-started/guides/move-money/crypto-travel-rule), so this can misreport or reject otherwise valid off-ramp deposits unless the source is constrained to a verified wallet or travel-rule data is submitted per movement once the real source is known.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
+ Coverage 72.46% 72.71% +0.25%
==========================================
Files 249 249
Lines 10091 10204 +113
Branches 3274 3306 +32
==========================================
+ Hits 7312 7420 +108
- Misses 2500 2501 +1
- Partials 279 283 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.