Skip to content

🚩 server: show declined transactions activity#1023

Open
aguxez wants to merge 1 commit into
mainfrom
declined-activities
Open

🚩 server: show declined transactions activity#1023
aguxez wants to merge 1 commit into
mainfrom
declined-activities

Conversation

@aguxez

@aguxez aguxez commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Declined activities now appear in activity listings (previously excluded).
  • Chores

    • Added a patch release entry noting the change to show declined transaction activity.

Review Change Stack

@changeset-bot

changeset-bot Bot commented May 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d105147

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cruzdanilo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 20 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: aacef69b-1053-4e9d-af95-db61afa5107a

📥 Commits

Reviewing files that changed from the base of the PR and between 23d7045 and d105147.

📒 Files selected for processing (2)
  • .changeset/small-bees-invite.md
  • server/api/activity.ts

Walkthrough

Removes the conditional filter that excluded declined activity items from the activity endpoint response, deletes the unused anvil import, and adds a changeset entry documenting a patch release that shows declined transactions activity.

Changes

Declined Activity Filter Removal

Layer / File(s) Summary
Remove declined activity filter and update imports
server/api/activity.ts, .changeset/small-bees-invite.md
Deletes the anvil import from viem/chains, removes the conditional .filter() that excluded items with status === "declined", so the activity response now includes those items; adds a changeset documenting the patch release.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • exactly/exa#1022: Modifies activity retrieval logic to exclude declined items, related to handling of declined activity data.
  • exactly/exa#971: Also touches activity API handling of declined transactions.

Suggested reviewers

  • nfmelendez
  • cruzdanilo
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title directly describes the main change: enabling declined transactions to be shown in the activity endpoint by removing filtering logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch declined-activities
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch declined-activities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the logic that filtered out declined activities from the activity API and removes the unused anvil chain import from server/api/activity.ts. A changeset is included to document this removal. I have no feedback to provide as there were no review comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6074dacdc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread server/api/activity.ts
@aguxez
aguxez force-pushed the declined-activities branch from f6074da to e9bc77e Compare May 19, 2026 13:33
@aguxez aguxez changed the title 🔥 server: remove declined activity filter 🚩 server: show declined txns activity May 19, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9bc77e9a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .changeset/small-bees-invite.md Outdated
@sentry

sentry Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.50%. Comparing base (f56a007) to head (d105147).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   74.57%   74.50%   -0.08%     
==========================================
  Files         243      243              
  Lines       11401    11326      -75     
  Branches     3902     3868      -34     
==========================================
- Hits         8502     8438      -64     
+ Misses       2571     2567       -4     
+ Partials      328      321       -7     
Flag Coverage Δ
e2e 73.78% <ø> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aguxez
aguxez force-pushed the declined-activities branch from e9bc77e to 23d7045 Compare May 19, 2026 14:28
@cruzdanilo cruzdanilo changed the title 🚩 server: show declined txns activity 🚩 server: show declined transactions activity Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants