[llhttp] 9.4.2-1: init package - #7976
Open
WeirdGumi wants to merge 1 commit into
Open
Conversation
![eweos-helper[bot]](https://avatars.githubusercontent.com/in/337143?s=60&v=4){kind=small}
ziyao233
requested changes
Jul 29, 2026
|
|
||
| prepare() { | ||
| cd $pkgname-$pkgver | ||
| npm install |
Member
There was a problem hiding this comment.
This is quite uncommon, why we must run npm install first? Please comment on this in PKGBUILD.
Comment on lines
+18
to
+23
| make RELEASE=$pkgver release | ||
| } | ||
|
|
||
| build() { | ||
| cmake -S $pkgname-$pkgver/release -B build -DCMAKE_INSTALL_PREFIX=/usr | ||
| cmake --build build |
Member
There was a problem hiding this comment.
It's quite uncommon, too, that both bare make and cmake are used. Please explain this in PKGBUILD.
github-project-automation
Bot
moved this from New
to ReqChanges
in eweOS Package Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.