Preserve environment when spawning sshfs#236
Open
Evesain wants to merge 1 commit into
Open
Conversation
Evesain
marked this pull request as ready for review
June 20, 2026 15:38
Author
|
@evsar3 @lancetekk @BRTPOB could this be looked into and implemented? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the existing Windows process environment when launching
sshfs.exe, while still prepending the SSHFS-Win binary directory toPATH.Root cause
ProcessHandlerWincurrently spawnssshfs.exewith an environment containing only:On current Windows setups this can break SSHFS-Win/Cygwin process startup before it reaches the remote SSH server. In my case SSHFS-Win Manager stayed stuck in
connecting, while direct SSH still worked. Reproducing the Manager launch command produced:Keeping the normal Windows environment and prepending SSHFS-Win's directory allows
sshfs.exeto start normally while still resolving the bundled SSHFS-Win binaries first.Validation
node --check src/renderer/ProcessHandlerWin.js.git diff --check.npm ciwas not runnable on the current upstream checkout becausepackage.jsonandpackage-lock.jsonare already out of sync for several dependencies; this PR intentionally avoids lockfile churn.