fix(examples): pin browser npm dependencies#2214
Open
chaliy wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 556c938 | Commit Preview URL | Jul 26 2026, 10:45 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
latestdist-tag and ignored the generated lockfile, creating a supply-chain risk where future unreviewed npm contents could execute on developer machines or in the browser.Description
@everruns/bashkit-wasmto0.14.3andviteto6.4.3inexamples/browser/package.jsonand tighten the test script to run the new security check.examples/browser/pnpm-lock.yamland remove the lockfile entry fromexamples/browser/.gitignoreso exact resolutions and integrity metadata are stored in the repo.examples/browser/dependency-security.test.js, a regression test that requires exact semantic versions and a committed lockfile.examples/browser/README.mdto requirepnpm install --frozen-lockfileand updatespecs/maintenance.mdto mandate frozen-lockfile installs and an explicit review/update workflow for dependency bumps.Testing
node --test dependency-security.test.jsfailed prior to the fix by detecting thelatestspecifier, demonstrating the detection works.pnpm install --frozen-lockfilefor the example which produced and validated the lockfile without errors.pnpm test(the browser example tests), which passed all tests (8/8).pnpm run buildfor the example and produced a successful Vite production build.Codex Task