fix(wasm): tolerate blocked browser storage#2213
Open
chaliy wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | ef65552 | Commit Preview URL | Jul 26 2026, 10:45 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
globalThis.localStorageas a default parameter, which can throw aSecurityErrorin sandboxed/opaque-origin/storage-blocked contexts and abort shell initialization.Description
globalThis.localStorageand treats storage as unavailable in that case.storage(configuredStorage) parameter while preserving existing behavior when callers pass a validStorageinstance.save()andclear()tolerant of unavailable storage by havingsave()returnfalseon write errors and wrappingclear()in atry/catchso failures do not throw.globalThis.localStoragegetter and verifiesload()returns defaults,save()reportsfalse, andclear()does not throw.Testing
node --test examples/browser/browser-local.test.jsand observed all tests pass (8passed).npm installthennpm run buildinexamples/browser), and thevite buildcompleted successfully.Codex Task