fix(wasm): reject unenforceable timeouts#2211
Open
chaliy wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 4c8be69 | Commit Preview URL | Jul 26 2026, 10:39 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
timeoutMs/timeout Nand allowed unresolved async callbacks to suspend execution indefinitely. This is an availability/control bypass for callers who rely on timeouts.Description
unsupported_timeout_response()and use it fromBashToolexecution paths so streaming, direct, andexecute_with_statuscalls return an explicit unsupported-timeoutToolResponse(exit code125) whentimeoutMsis supplied on wasm targets.ScriptedToolto returnunsupported_timeout_response()on wasm when a per-call timeout is requested instead of ignoring the deadline and awaiting orchestration futures.timeoutbuiltin in the interpreter to fail closed on wasm by returning anExecResultwith an explanatory message and exit code125without dispatching the inner command when the builtin is given a wall-clock timeout on wasm targets.crates/bashkit-wasm/README.md,specs/browser-package.md, andspecs/limitations.mdto document the fail-closed contract.Testing
cargo check -p bashkit --target wasm32-unknown-unknown --features scripted_tool,jqandcargo test -p bashkit test_tool_execute_timeout, and the unit testtest_tool_execute_timeoutpassed.cargo clippy(native and wasm-target slices with-- -D warnings) andcargo fmt --check; linters and format checks passed after the changes.cargo buildsucceeded butwasm-bindgenCLI was not present in the environment so fullwasm-bindgenpackaging was not executed in this run (adjust local build environment to runbash crates/bashkit-wasm/scripts/build.shend-to-end).Codex Task