Skip to content

Remove flag --max-snapshots and --v2-deprecation - #22306

Open
ahrtr wants to merge 2 commits into
etcd-io:mainfrom
ahrtr:20260819_v2_flags
Open

Remove flag --max-snapshots and --v2-deprecation#22306
ahrtr wants to merge 2 commits into
etcd-io:mainfrom
ahrtr:20260819_v2_flags

Conversation

@ahrtr

@ahrtr ahrtr commented Aug 19, 2026

Copy link
Copy Markdown
Member

part of #20187

The v2store is completely gone, so remove both flag --max-snapshots and --v2-deprecation.

ahrtr added 2 commits August 19, 2026 16:09
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
…precation

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr

ahrtr commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

/retest

cc @fuweid @ivanvc @serathius

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.67%. Comparing base (7b2ad21) to head (9dbb2d9).

Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <ø> (ø)
server/embed/config.go 79.56% <100.00%> (+0.09%) ⬆️
server/embed/etcd.go 75.73% <ø> (-0.17%) ⬇️
server/etcdmain/config.go 69.82% <ø> (-3.66%) ⬇️
server/etcdserver/server.go 83.68% <100.00%> (-0.09%) ⬇️

... and 13 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22306      +/-   ##
==========================================
+ Coverage   69.64%   69.67%   +0.02%     
==========================================
  Files         449      448       -1     
  Lines       38196    38155      -41     
==========================================
- Hits        26602    26584      -18     
+ Misses      10163    10147      -16     
+ Partials     1431     1424       -7     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2ad21...9dbb2d9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants