Deflake TestValidateLinearizableOperationsTimeoutIsRepected - #22258
Deflake TestValidateLinearizableOperationsTimeoutIsRepected#22258Hrishi-Baskaran wants to merge 1 commit into
Conversation
|
Hi @Hrishi-Baskaran. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c5bb486 to
4637a94
Compare
|
@spzala, @serathius could you please review? |
|
Hey @serathius just curious about how multi-commit PRs should match etcd's commit format? Should I squash before I request a review or should I squash and merge, just keeping the first commit to hold the main information about the PR? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Hrishi-Baskaran, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Let's just squash. Commit format is very old and we didn't really follow it. At least until AI came. I personally don't see the value. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 31 files with indirect coverage changes @@ Coverage Diff @@
## main #22258 +/- ##
==========================================
- Coverage 69.75% 69.65% -0.10%
==========================================
Files 449 449
Lines 38212 38193 -19
==========================================
- Hits 26653 26605 -48
- Misses 10134 10165 +31
+ Partials 1425 1423 -2 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…utIsRespected Removes an uneccessary assertion that involves comparing executed time of validateLinearizableOperationsAndVisualize to the wall clock elapsed duration. This is inherently nondeterministic. validateLinearizableOperationsAndVisualize is a somewhat thin wrapper around porcupine.CheckOperationsVerbose. We were essentially just checking if the timeout of porcupine.CheckOperationsVerbose works. We should instead just keep the tests that verify what our wrapper does: carry the timeout info into the result.Message Signed-off-by: Hrishi Baskaran <hrishithevar@gmail.com>
433af57 to
e5a789d
Compare
2 participants
Resolves #22257
Removes an unnecessary assertion that involves comparing executed time of
validateLinearizableOperationsAndVisualizeto the wall clock elapsed duration. This is inherently nondeterministic.I was able to cause this assertion to fail with stress
validateLinearizableOperationsAndVisualizeis a somewhat thin wrapper aroundporcupine.CheckOperationsVerbose. We were essentially just checking if the timeout ofporcupine.CheckOperationsVerboseworks. We should instead just keep the tests that verify what our wrapper does: carry the timeout info into theresult.Message.Also reduces the timeout to one nanosecond to ensure that the timeout triggers for very fast machines. I coudn't get this to trigger with stress but I thought it would be a good idea to also eliminate this source of nondeterminism as well.