Skip to content

tests: Migrate IgnoreValue and IgnoreLease tests to common framework - #22256

Open
akstron wants to merge 1 commit into
etcd-io:mainfrom
akstron:dev/ignore-test-to-common-framework
Open

tests: Migrate IgnoreValue and IgnoreLease tests to common framework#22256
akstron wants to merge 1 commit into
etcd-io:mainfrom
akstron:dev/ignore-test-to-common-framework

Conversation

@akstron

@akstron akstron commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #20550
Part of #13637

@kubernetes-prow

Copy link
Copy Markdown

Hi @akstron. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akstron

akstron commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@serathius can you help with reviewing this?

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akstron, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius

Copy link
Copy Markdown
Member

/ok-to-test

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.64%. Comparing base (3e3b4c1) to head (d11bd05).
⚠️ Report is 95 commits behind head on main.

Additional details and impacted files

see 33 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22256      +/-   ##
==========================================
- Coverage   69.65%   69.64%   -0.01%     
==========================================
  Files         449      449              
  Lines       38188    38196       +8     
==========================================
+ Hits        26599    26602       +3     
- Misses      10154    10164      +10     
+ Partials     1435     1430       -5     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3b4c1...d11bd05. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
@akstron
akstron force-pushed the dev/ignore-test-to-common-framework branch from a33d6d9 to d11bd05 Compare August 19, 2026 17:57
@akstron

akstron commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@akstron

akstron commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants