Skip to content

Navigation and content-layout redesign#2016

Open
GregorShear wants to merge 12 commits into
mainfrom
greg/dash/nav
Open

Navigation and content-layout redesign#2016
GregorShear wants to merge 12 commits into
mainfrom
greg/dash/nav

Conversation

@GregorShear

@GregorShear GregorShear commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the top app bar. The sidebar now owns branding, navigation, and utility actions, and each page gets a slim content header with the page title and docs toggle.

Screenshot 2026-07-06 at 5 01 53 PM Screenshot 2026-07-06 at 5 02 28 PM

@GregorShear
GregorShear requested a review from a team as a code owner June 26, 2026 19:35
@GregorShear
GregorShear force-pushed the greg/dash/nav branch 3 times, most recently from 0aa045d to 5e3230c Compare July 2, 2026 17:41
@GregorShear
GregorShear changed the base branch from main to claude/nav-drawer-to-box July 2, 2026 17:41
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

✅ Code Health

Removes $\textcolor{green}{1}$ dead-code issue, introduces none.

48 Unused files $\textcolor{green}{-1}$

File imported nowhere — delete (or import) it.

$\textcolor{green}{-}$ src/components/shared/RelativeAppBar.tsx
     src/hooks/useDelay.ts
     src/hooks/useDraft.ts
     src/pages/NoGrants.tsx
     src/pages/OAuth.tsx
     src/services/encryption.ts
     src/types/global.ts
     src/types/vitest.ts
     src/components/graphs/TaskHoursByMonthGraph.tsx
     src/components/tables/Link.tsx
…and 39 more

64 Unused exports

Exported symbol with no references outside its own file — un-export it, or delete it if unused entirely

     src/context/Theme.tsx : logoColors
     src/context/Theme.tsx : intensifiedOutlineThick
     src/context/Theme.tsx : tableAlternateRowsSx
     src/context/Theme.tsx : draggableChipIconSx
     src/context/Theme.tsx : hiddenButAccessibleInput
     src/context/Theme.tsx : primaryColoredBackground_hovered
     src/context/Theme.tsx : detailsPanelBgColor
     src/context/Theme.tsx : menuBackgroundColor
     src/context/Theme.tsx : flexGrowToSiblingsSx
     src/context/Theme.tsx : shardTableRow
…and 54 more

26 Unused exported types

Exported type with no references outside its own file — un-export it, or delete it if unused entirely

     src/utils/billing-utils.ts : FREE_GB_BY_TIER
     src/types/index.ts : InferredSchemas
     src/types/index.ts : Shard
     src/components/shared/WizardDialog/index.ts : WizardStep
     src/api/dataPlanes.ts : AwsDnsEntry
     src/stores/ShardDetail/types.ts : TaskShardDetailsWithShard
     src/stores/ShardDetail/types.ts : ShardDetails
     src/components/tables/Logs/types.ts : RefreshLogsFunction
     src/types/schemaModels.ts : CollectionSchema
     src/components/editor/Bindings/types.ts : SelectedCollectionChangeData
…and 16 more

14 Unused exported enum members

An enum member referenced nowhere

     src/services/supabase.ts : CONNECTOR_TAGS
     src/services/supabase.ts : DRAFTS_EXT
     src/services/supabase.ts : TASKS_BY_DAY
     src/stores/Tables/hooks.ts : accessGrants
     src/stores/Tables/hooks.ts : accessLinks
     src/stores/Tables/hooks.ts : billing
     src/stores/Tables/hooks.ts : connectors
     src/stores/Tables/hooks.ts : entitySelector
     src/stores/Tables/hooks.ts : prefixes
     src/stores/Tables/hooks.ts : prefixAlerts
…and 4 more

5 Unused dependencies

In package.json but never imported

     package.json : @mui/lab
     package.json : @testing-library/jest-dom
     package.json : @urql/exchange-retry
     package.json : logrocket-react
     package.json : stripe

3 Unused devDependencies

In package.json devDependencies but never used

     package.json : @types/logrocket-react
     package.json : @types/react-inspector
     package.json : sharp

@GregorShear
GregorShear force-pushed the claude/nav-drawer-to-box branch from cb9661b to 521e1bd Compare July 2, 2026 21:31
Base automatically changed from claude/nav-drawer-to-box to main July 6, 2026 20:28
@GregorShear
GregorShear requested a review from jshearer July 6, 2026 20:29
this is the precursor UI work that makes room for the dashboard agent feature
FullPageError renders before the sidebar (and its logout) mounts, so add Reload and Logout buttons to keep those dead-end screens escapable. Also drop the stray Toolbar spacer in FullPageWrapper that left a ~64px gap.
The toast used theme.zIndex.snackbar (1400), above MUI's modal layer (1300), so an undismissed toast floated bright and clickable over dialog backdrops. Use theme.zIndex.drawer (1200) so dialogs sit above it.
The content-area restyle dropped EntityTable's title-above-toolbar for showToolbar tables. That's fine for single-table pages, but Admin > Access Grants stacks two tables whose only labels were those titles, leaving them indistinguishable. Render each table's heading in AccessGrantsTable so Organization Membership and Data Sharing are labeled again.
iconoir-react icons default to 1.5em, so setting style={{ fontSize }} rendered them 1.5x larger than the number implies: the toast dismiss X was 30px in a 20px button, the Read the docs arrow 21px, and the pill tooltip arrow 24px. Use explicit width/height (and restore strokeWidth on the toast arrow) so they render at their intended sizes.
@kiahna-tucker
kiahna-tucker self-requested a review July 15, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants