control-plane-api: surface per-store health diagnostics in storage-mapping mutations#3181
Open
GregorShear wants to merge 1 commit into
Open
control-plane-api: surface per-store health diagnostics in storage-mapping mutations#3181GregorShear wants to merge 1 commit into
GregorShear wants to merge 1 commit into
Conversation
GregorShear
force-pushed
the
greg/storage-health-diagnostics
branch
from
July 17, 2026 15:59
bd549fa to
e7b7dc4
Compare
GregorShear
changed the base branch from
johnny/gazette-fragment-store-errors-057e0d
to
master
July 17, 2026 16:00
|
🚀 Preview deployed to https://docs.estuary.dev/pr-preview/pr-3181/ |
…pping mutations createStorageMapping and updateStorageMapping ran per-store fragment-store health checks but collapsed any failure into a generic "Storage health checks failed" error, discarding the per-store diagnostics that run_all_health_checks had already collected. Building on the gazette change that surfaces the store's real error string, thread those diagnostics into both mutation errors: a new describe_health_failures helper renders each failing check as its store URL, data-plane name, and the store's own error. testConnectionHealth already returned full per-store results and is unchanged.
GregorShear
force-pushed
the
greg/storage-health-diagnostics
branch
from
July 17, 2026 23:58
e7b7dc4 to
641c91d
Compare
GregorShear
marked this pull request as ready for review
July 18, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage mapping mutations run a health check to verify reachability between dataplanes and storage buckets, but until recently the journal client was swallowing diagnostic info on failed tests.
This PR plumbs the new Error::FragmentStoreUnhealthy through to the gql mutation errors so the UI can surface it to users.