feat: restrict types allowed during deserialization via ITypeFilter#182
Merged
Conversation
Add an opt-in type allow-list for expression deserialization, the equivalent of BinaryFormatter's SerializationBinder, so untrusted payloads cannot resolve arbitrary types. - ITypeFilter extension point on ExpressionContext (TypeFilter property + constructor overloads); enforced in ExpressionContextBase.ResolveType - Built-in AllowedTypesFilter (allow-list by type/open-generic/namespace) and DelegateTypeFilter (predicate) - TypeNotAllowedException thrown for rejected types - Filter applied on cache hits and to each generic argument, so it cannot be bypassed; no filter set keeps existing behavior unchanged - Add ExpressionSerializer.Deserialize(Stream, IExpressionContext) overload - Tests in Issues/Issue151.cs (90/90 passing) - Bump version to 4.3.0; update CHANGELOG and README Closes #151 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in type allow-list for expression deserialization, the equivalent of BinaryFormatter's SerializationBinder, so untrusted payloads cannot resolve arbitrary types.
Closes #151