fix: recover transient sync timeouts#76
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 64.34% 64.53% +0.18%
==========================================
Files 49 49
Lines 6575 6644 +69
==========================================
+ Hits 4231 4288 +57
- Misses 2037 2041 +4
- Partials 307 315 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang.org/x/textto the version fixing reachable GO-2026-5970Root cause
Walmart's upstream client retries rate limits but not HTTP client timeouts. The sync also made a single Monarch update attempt and treated an ambiguous timeout as a definitive failure, even though the mutation could have landed. On a later run, the aggregate matcher could select that enlarged primary transaction without cleaning up an undeleted component. Separately, summary wording only checked whether any order was processed.
While validating the PR,
govulncheckfound a reachable infinite-loop vulnerability in the selectedgolang.org/x/text v0.37.0; upstream fixes it inv0.39.0.Impact
Transient provider timeouts no longer immediately fail recoverable orders. If a Monarch consolidation update landed without a response, Itemize resumes only when the primary amount and exact original charge note prove the interrupted state, then removes the matched leftovers before applying splits. Production summaries no longer claim full success when orders failed, and the reachable text-processing vulnerability is removed.
Validation
make pre-commit-localgo test ./... -racego build -o itemize ./cmd/itemize/go run golang.org/x/vuln/cmd/govulncheck@v1.3.0 ./...