fix: process Walmart in-store receipt charges#73
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 61.81% 61.89% +0.08%
==========================================
Files 46 46
Lines 6021 6034 +13
==========================================
+ Hits 3722 3735 +13
Misses 2046 2046
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
IN_STOREorder has exactly oneCREDITCARDpayment and its ledger is emptyRoot cause
Walmart returns complete payment metadata and totals for in-store receipts on the order payload, but its separate order-ledger endpoint returns no payment methods. Itemize treated every empty ledger as an uncharged order, so completed in-store purchases were skipped indefinitely.
Validation
go test ./... -racego vet ./...$9.88,$32.10, and$10.69Monarch transactions and finishedProcessed=3 Skipped=0 Errors=0