Declare the DataValidation plugin dependency in the descriptor - #1
Open
DegradingAnt wants to merge 1 commit into
Open
Declare the DataValidation plugin dependency in the descriptor#1DegradingAnt wants to merge 1 commit into
DegradingAnt wants to merge 1 commit into
Conversation
The module depends on the DataValidation module (ModValidation.Build.cs, in PrivateDependencyModuleNames, for UEditorValidatorBase and UEditorValidatorSubsystem), but ModValidation.uplugin declared no Plugins array at all. UnrealBuildTool warns on every build: Warning: Plugin 'ModValidation' does not list plugin 'DataValidation' as a dependency, but module 'ModValidation' depends on module 'DataValidation'. Verified against the Coffee Stain UE 5.6.1 fork used by SML: with the dependency declared, a FactoryEditor Win64 Development build emits no such warning and reports Result: Succeeded. Before the change the same build emitted it at line 26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModValidation.Build.cslistsDataValidationinPrivateDependencyModuleNames, but the descriptor never declares the plugin, so UBT warns on every build:Adds the
Pluginsentry. Six lines, no code change.Built before and after against the CSS 5.6.1 engine,
FactoryEditor Win64 Development: warning gone,Result: Succeededeither way,UnrealEditor-ModValidation.dllstill links. So it is a descriptor fix, not a behavior change.Picked the plugin up for a Satisfactory mod after CL502094 and hit this on the first build. Useful tool, the dangling
TSubclassOfcheck in particular.