feat(design-system): establish Phase 5A.1a foundations - #1263
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d233428299
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function classTokenCount(source: string, token: string): number { | ||
| const attributes = /\b(?:className|class)\s*=\s*(?:"([^"]*)"|'([^']*)'|`([^`]*)`)/gu; |
There was a problem hiding this comment.
Count class tokens inside JSX expressions
The ratchet ignores the common className={...} form because the regex requires a quote or backtick immediately after =. Existing usages such as ProductScoreHero.tsx's className={`card ${band.bgColor} border-0`} are therefore absent from the committed inventory, and future card or input-field debt written this way can increase without failing assertShrinkOnlyVisualDebt, undermining the shrink-only gate.
Useful? React with 👍 / 👎.
| import type { CatalogCopy } from "./registry"; | ||
|
|
||
| const feedbackTones = ["info", "success", "warning", "error", "neutral"] as const; | ||
| const chipTones = ["neutral", "action", "success", "warning", "error", "info", "neutral"] as const; |
There was a problem hiding this comment.
Give the Subtle chip its own tone
In every locale the seventh chip label is “Subtle,” but its tone repeats neutral, and the stylesheet has no separate subtle selector. Consequently all 18 foundation capture cases present Neutral and Subtle with identical styling, so the 90-image candidate package cannot truthfully support the pending human review of that semantic role; either map it to a distinct subtle treatment or remove the duplicate specimen.
Useful? React with 👍 / 👎.
Purpose
Finish Phase 5A.1a, the first of exactly two Design System V2 foundation PRs, while keeping every production route on the byte-compatible V1 visual contract. Living Label and the current mark are provisional working hypotheses; Phase 5A.2 must challenge them before any production redesign begins.
What changes
data-design-system="v1"./dev/componentsas a doubly gated, localized EN/PL/DE foundation catalog using honest V2 specimens rather than rendering V1 components inside V2 scope.Future contract documentation only
Compatibility and non-scope
main; the branch is synchronized with basee8086060b33fe4132bc3c67d7613913e6493dc33.candidate-not-adopted; the system stack remains active and serif adoption remains deferred to the later human art-direction gate.Authored vs generated artifacts
frontend/src/design-system/generated/tokens.css,frontend/src/design-system/generated/tokens.ts,docs/assets/design-tokens.json, anddocs/phase5/live-route-component-inventory.json.014FF7543197D7B5D455E9B00B2221ED53ADD9FFDCA621BDC7DAEDAA2A32B28F.Local verification
npm run design-system:check— 7 files / 46 tests passed; generated token artifacts current.npm run type-check, full source lint, explicit tooling/E2E lint, production build, andgit diff --checkpassed.Accessibility, performance, and visual review
Exact-head acceptance evidence
Final PR head:
d23342829931da7815b7121128c8fdaada794d55Reviewed merge ref:
34a2e315092ec7283f22a5a77b90dee0785beaccReviewed tree:
0296dace649b9b3efbb1617d50ad2951de12ad4631365081674: passed. The corrected unit job completed all 6,481 tests, timing summary, and artifact upload; timing artifact9053938535.31365081766and GHAS check93381875230: passed; zero open alerts.31365081769: passed all public/local lifecycles and 18/18 catalog cases. Candidate artifact9054003661, ZIP SHA-256d611ba538c39a081d36f61ea9f7ca158d266eeaa63ebc830c609abc0decde009, manifest SHA-25627c9662f7fdd8e6f6509279d639fd5b8758fef7238c013290c9c4cf5a65251ff. All 72 scene PNGs and 18 contact sheets were independently verified.31365081819: passed 5 public + 3 authenticated comparisons; no baseline diff. Manifest checksum12a00dc37191191b788964d1c599d103aa0fedb1c15fa8cc36ad80d746953716.31365081706: passed all five fail-if-either guards. Artifact9054042997, SHA-256f667a99923887f783e6e18c81ec99f44306cf6aa2fa1fe309d1eb16589122fe2.31365081680, attempt 1: passed 50 measurements, zero blocking failures, and zero instability failures. Artifact9054220812, SHA-256dada00e00b7fa5a7581eeb8ab5bc36715f7aaa0e4448007a2c7f0d66b6aaa462; report checksum9a02c57f60f21b58554e3bfa02ff600a6346c396a6273a02e5afceac558e4829.31365492903: sole exact-head dispatch, passed. Sonar job93384044051analyzed the exact revision: reliability/security/maintainability A, 91.2% new coverage, 1.4% new duplication, and 100% hotspot review.Pending human acceptance — keep draft
mainSHA is verified, and Eric explicitly authorizes the next phase.