Skip to content

fix(fmuobs): downgrade validation errors to warnings #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnyb merged 1 commit into from
Aug 12, 2026
Merged

fix(fmuobs): downgrade validation errors to warnings #882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/subscript/fmuobs/fmuobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def validate_internal_dframe(obs_df: pd.DataFrame) -> bool:
failed = True
non_supported_classes = set(obs_df["CLASS"]) - set(CLASS_SHORTNAME.keys())
if non_supported_classes:
logger.error("Unsupported observation classes: %s", non_supported_classes)
logger.warning("Unsupported observation classes: %s", non_supported_classes)
failed = True
Comment on lines 167 to 170

index = {"CLASS", "LABEL", "OBS", "SEGMENT"}.intersection(set(obs_df.columns))
Expand Down Expand Up @@ -342,7 +342,7 @@ def fmuobs(
dframe = compute_date_from_days(dframe, starttime=starttime)

if not validate_internal_dframe(dframe):
logger.error("Observation dataframe is invalid!")
logger.warning("Observation dataframe is invalid or has invalid data.")

# Trigger warning if user specify ERROR_MODE != ABS
# in BLOCK_OBSERVATION and SUMMARY_OBSERVATION
Expand Down