Skip to content

convert_grid_format: Add roff2ecl grid mode - #880

Merged
alifbe merged 1 commit into
equinor:mainfrom
alifbe:convert-grid-roff2ecl
Aug 9, 2026
Merged

convert_grid_format: Add roff2ecl grid mode#880
alifbe merged 1 commit into
equinor:mainfrom
alifbe:convert-grid-roff2ecl

Conversation

@alifbe

@alifbe alifbe commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Add roff2ecl conversion to convert_grid_format. Currently only support gridmode

@alifbe
alifbe requested a balanced review from Copilot August 9, 2026 09:59
@codecov-commenter

codecov-commenter commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.58%. Comparing base (af56c88) to head (e20402c).

Files with missing lines Patch % Lines
...bscript/convert_grid_format/convert_grid_format.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   84.52%   84.58%   +0.05%     
==========================================
  Files          49       49              
  Lines        7401     7432      +31     
==========================================
+ Hits         6256     6286      +30     
- Misses       1145     1146       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds ROFF-to-ECLIPSE grid conversion to the CLI and ERT integration.

Changes:

  • Supports GRDECL, binary GRDECL, and EGRID output.
  • Adds the ROFF2ECLGRID forward-model step.
  • Adds unit, integration, and documentation coverage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
convert_grid_format.py Implements ROFF-to-ECLIPSE conversion.
forward_model_steps.py Registers and documents ROFF2ECLGRID.
test_convert_grid_format.py Tests formats, validation, inference, and ERT integration.
test_hook_implementations.py Verifies forward-model registration.
overview.rst Lists the new forward model.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/subscript/convert_grid_format/convert_grid_format.py Outdated
@alifbe
alifbe force-pushed the convert-grid-roff2ecl branch from 31cd318 to e6d204a Compare August 9, 2026 11:40
@alifbe
alifbe requested a balanced review from Copilot August 9, 2026 11:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@alifbe
alifbe marked this pull request as ready for review August 9, 2026 12:41
@alifbe
alifbe requested a review from a team August 9, 2026 12:41

@rnyb rnyb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Comment thread docs/overview.rst Outdated
@alifbe
alifbe force-pushed the convert-grid-roff2ecl branch from e6d204a to e20402c Compare August 9, 2026 19:39
@alifbe
alifbe merged commit 363a18f into equinor:main Aug 9, 2026
7 checks passed
@alifbe
alifbe deleted the convert-grid-roff2ecl branch August 9, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants