convert_grid_format: Add roff2ecl grid mode - #880
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
+ Coverage 84.52% 84.58% +0.05%
==========================================
Files 49 49
Lines 7401 7432 +31
==========================================
+ Hits 6256 6286 +30
- Misses 1145 1146 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds ROFF-to-ECLIPSE grid conversion to the CLI and ERT integration.
Changes:
- Supports GRDECL, binary GRDECL, and EGRID output.
- Adds the
ROFF2ECLGRIDforward-model step. - Adds unit, integration, and documentation coverage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
convert_grid_format.py |
Implements ROFF-to-ECLIPSE conversion. |
forward_model_steps.py |
Registers and documents ROFF2ECLGRID. |
test_convert_grid_format.py |
Tests formats, validation, inference, and ERT integration. |
test_hook_implementations.py |
Verifies forward-model registration. |
overview.rst |
Lists the new forward model. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alifbe
force-pushed
the
convert-grid-roff2ecl
branch
from
August 9, 2026 11:40
31cd318 to
e6d204a
Compare
alifbe
marked this pull request as ready for review
August 9, 2026 12:41
alifbe
force-pushed
the
convert-grid-roff2ecl
branch
from
August 9, 2026 19:39
e6d204a to
e20402c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
roff2eclconversion toconvert_grid_format. Currently only supportgridmode