Skip to content

Migrate Weibull distribution to per-type S3 interface#48

Merged
sbfnk merged 1 commit into
mainfrom
migrate-weibull
Jul 16, 2026
Merged

Migrate Weibull distribution to per-type S3 interface#48
sbfnk merged 1 commit into
mainfrom
migrate-weibull

Conversation

@sbfnk-bot

Copy link
Copy Markdown
Collaborator

Description

This PR closes part of #41: it migrates the Weibull distribution to the per-distribution S3 interface, continuing the refactor already landed for Gamma(), Normal(), LogNormal() and Exp().

R/weibull.R now holds natural_params.weibull, lower_bounds.weibull, dist_cdf.weibull, mean.weibull and sd.weibull, and the five weibull switch() arms in dist_spec.R delegate to these via new_dist("weibull"). Behaviour is unchanged: mean scale * Γ(1 + 1/shape), sd scale * sqrt(Γ(1 + 2/shape) − Γ(1 + 1/shape)²), CDF pweibull, natural parameters shape/scale.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (all 36 tests pass).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes.
  • I have followed the established coding standards (checked with lintr).
  • I have added a news item linked to this PR.

Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
@sbfnk-bot sbfnk-bot requested a review from sbfnk July 16, 2026 07:38
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sbfnk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9b149696-badc-4522-ab51-2ef9f3c86eff

📥 Commits

Reviewing files that changed from the base of the PR and between 6b94414 and aef6d07.

📒 Files selected for processing (4)
  • NAMESPACE
  • NEWS.md
  • R/dist_spec.R
  • R/weibull.R
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch migrate-weibull

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sbfnk-bot sbfnk-bot added the claude-reviewed Reviewed by the wait-for-review loop label Jul 16, 2026
@sbfnk sbfnk marked this pull request as ready for review July 16, 2026 07:40
@sbfnk sbfnk added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit 5e619e5 Jul 16, 2026
12 checks passed
@sbfnk sbfnk deleted the migrate-weibull branch July 16, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-reviewed Reviewed by the wait-for-review loop

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants