feat(vendor): integrate vendor results and banners into query previews - #2149
Merged
Conversation
victorcg88
previously approved these changes
Aug 4, 2026
AdrianArenal
force-pushed
the
ENG-1503-vendor-query-previews
branch
from
August 4, 2026 09:37
c311fdb to
73ec126
Compare
victorcg88
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fulfill all customers requirements about vendor results and banners, we need to include them also on query previews:

A data-query-preview-hash is now exposed on each query preview DOM element so anyone can inspect the DOM and search for the hash id of the query preview. Then, they just have to emit events with info like:
Pull request template
Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: