Image.write/3: accept :average or Pixel.t() as :background#206
Open
hlindset wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to set
Image.write/3's:backgroundoption to:averageorPixel.t().The original
:backgroundhandling forImage.write/3just guardedis_pixel, and then pushed the raw value into vix, causingprotocol Enumerable not implemented for ...for anything other than numeric lists.image/lib/image/options/write.ex
Lines 301 to 303 in 5bb98af
Open questions:
:averagerequired threading the image through all validation functions, so all function heads had to be updated. If you'd prefer I could do it in a resolve/validate step after the main validation has completed.Image.Options.Write.invalid_option/1for errors not bound to a specific image type, but the return type of that is%Image.Error{}, notbinary()likeImage.Options.Write.invalid_option/2. Is that ok, or should I switch both to either%Image.Error{}orbinary()?