Add mix ecto.query task#733
Open
cdvx wants to merge 3 commits into
Open
Conversation
Closes elixir-ecto/ecto#4719 Implements a read-only query Mix task run through the selected or default repo. Accepts --sql to render generated SQL and params for the passed query without running it, otherwise returns schema level output. Raises is adapter does not support read only transactions.
josevalim
reviewed
Jun 21, 2026
josevalim
reviewed
Jun 21, 2026
josevalim
reviewed
Jun 21, 2026
josevalim
reviewed
Jun 21, 2026
josevalim
reviewed
Jun 21, 2026
josevalim
reviewed
Jun 21, 2026
josevalim
left a comment
josevalim
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay, I dropped what is likely the final batch of comments and we should be good!
Co-authored-by: José Valim <jose.valim@gmail.com>
- clean up tests - use inspect_fun opt instead of overriding global state for inspect - copy implementation of inspect/4 Inspect.Map protocol instead of calling private API directly - parse only aliases from .iex.exs
Author
No worries at all, thanks for the thorough review! I’ve addressed the comments: . |
v0idpwn
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes elixir-ecto/ecto#4719
Implements a read-only query Mix task run through the selected or default repo. Accepts --sql to render generated SQL and params for the passed query without running it, otherwise returns schema level output. Raises is adapter does not support read only transactions.