support for hostname config field, and added ready status to fix issue on initial connection#32
Open
mayel wants to merge 1 commit into
Open
support for hostname config field, and added ready status to fix issue on initial connection#32mayel wants to merge 1 commit into
hostname config field, and added ready status to fix issue on initial connection#32mayel wants to merge 1 commit into
Conversation
…sues on initial connection
Member
|
Hey @mayel thanks for this PR, I’m properly not going to merge this as is, as I’m getting ready to commit a bigger refactor of the the pool that addresses the not readiness. Regardless we do need to address the hostname. |
Author
|
Sounds good! I'll wait for your refactor before proceeding with it then :) |
Member
Awesome, I just comitted what I've been working on. You might be hitting some subtle bugs that I'm still working on but you should be able to rebase your PR and adjust your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this lib looks really interesting, thanks!
Here's a PR for a couples issues I encountered when trying it out.