Skip to content

App: use correct GPU name - #600

Merged
lenemter merged 1 commit into
mainfrom
lenemter/fix-switcheroo-gpu-name
Aug 14, 2026
Merged

App: use correct GPU name#600
lenemter merged 1 commit into
mainfrom
lenemter/fix-switcheroo-gpu-name

Conversation

@lenemter

Copy link
Copy Markdown
Member

Fixes #581

The switcheroo_control.get_gpu_name (bool default_gpu) method, as its signature indicates, takes whether to return default GPU name. In case where app prefers non-default gpu, we need to get default name, and vice versa. But this was inversed when the switcheroo was introduced in #228

@lenemter
lenemter requested a review from a team August 14, 2026 07:50
@flodavid

flodavid commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Are you sure about this ? Since the parameter in Switcheroo is named default_gpu, it makes sense to negate the value of prefers_nondefault_gpu when we call it. If this change is necessary, it means there is something wrong in the Switcheroo method.
Edit: I got it now, sorry, we do want the opposite of the GPU preference here. The parameter name default_gpu in Switcheroo is a bit confusing though.

@lenemter
lenemter merged commit 8b9f861 into main Aug 14, 2026
4 checks passed
@lenemter
lenemter deleted the lenemter/fix-switcheroo-gpu-name branch August 14, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dock context menu reports wrong GPU in some cases.

2 participants