Skip to content

Port to GTK4 - #29

Open
danirabbit wants to merge 11 commits into
mainfrom
danirabbit/gtk4
Open

Port to GTK4#29
danirabbit wants to merge 11 commits into
mainfrom
danirabbit/gtk4

Conversation

@danirabbit

Copy link
Copy Markdown
Member

Fixes #8

@danirabbit danirabbit moved this to In progress in OS 8.1.0 Jun 30, 2025
@danirabbit danirabbit removed this from OS 8.1.0 Oct 3, 2025
@danirabbit danirabbit moved this to In Progress in GTK4 Porting Apr 15, 2026
@zeebok

This comment was marked as outdated.

@danirabbit

This comment was marked as outdated.

Comment thread src/Dialog/ReceiverDialog.vala Outdated
Comment thread src/Dialog/SenderDialog.vala Outdated
@danirabbit
danirabbit requested a review from ryonakano August 18, 2026 16:29
@danirabbit

Copy link
Copy Markdown
Member Author

@ryonakano think I fixed this how it's supposed to be. We set hide_on_close property based on the status change of transfer and then call close instead of destroy

@danirabbit
danirabbit marked this pull request as ready for review August 18, 2026 17:50
remove_session.begin ();
}
}
destroy ();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected that this destroy () is just removed instead of being replaced by close ()?

I expected this:

        response.connect ((response_id) => {
            if (response_id == Gtk.ResponseType.CANCEL) {
                if (transfer != null) {
                    if (transfer.status == "active") {
                        try {
                            transfer.cancel ();
                        } catch (Error e) {
                            GLib.warning (e.message);
                        }
                        remove_session.begin ();
                    }
                }
            }

            close ();
        });

Comment thread src/Application.vala
bt_senders.append (bt_sender);
bt_sender.present ();
bt_sender.destroy.connect (() => {
((Gtk.Widget) bt_sender).destroy.connect (() => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SenderDialog and ReceiverDialog now calls close () instead of destroy () but is destroy () signal still emitted? Doesn't we need to modify this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an issue that ScanDialog never closes even if I click Close button, which only happens when the dialog has been once opened and then closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Port to GTK 4

3 participants