Port to GTK4 - #29
Open
danirabbit wants to merge 11 commits into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ryonakano
reviewed
Jul 28, 2026
Member
Author
|
@ryonakano think I fixed this how it's supposed to be. We set |
danirabbit
marked this pull request as ready for review
August 18, 2026 17:50
ryonakano
reviewed
Aug 19, 2026
| remove_session.begin (); | ||
| } | ||
| } | ||
| destroy (); |
Member
There was a problem hiding this comment.
Is this expected that this destroy () is just removed instead of being replaced by close ()?
I expected this:
response.connect ((response_id) => {
if (response_id == Gtk.ResponseType.CANCEL) {
if (transfer != null) {
if (transfer.status == "active") {
try {
transfer.cancel ();
} catch (Error e) {
GLib.warning (e.message);
}
remove_session.begin ();
}
}
}
close ();
});| bt_senders.append (bt_sender); | ||
| bt_sender.present (); | ||
| bt_sender.destroy.connect (() => { | ||
| ((Gtk.Widget) bt_sender).destroy.connect (() => { |
Member
There was a problem hiding this comment.
SenderDialog and ReceiverDialog now calls close () instead of destroy () but is destroy () signal still emitted? Doesn't we need to modify this?
Member
There was a problem hiding this comment.
I found an issue that ScanDialog never closes even if I click Close button, which only happens when the dialog has been once opened and then closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8