Skip to content

Allow .artifacts for changelog CI I/O - #3913

Open
lcawl wants to merge 1 commit into
mainfrom
changelog-hidden-directories
Open

Allow .artifacts for changelog CI I/O#3913
lcawl wants to merge 1 commit into
mainfrom
changelog-hidden-directories

Conversation

@lcawl

@lcawl lcawl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Unblock changelog submit by allowlisting .artifacts in docs-builder’s changelog CI filesystems.
Also requires elastic/docs-actions#308

Problem

There are a lot of changelog-submit failures since we turned on automatic chagnelog creation in docs-content.
They come from docs-actions passing .artifacts/... paths into docs-builder changelog prepare-artifact, which uses Nullean.ScopedFileSystem and rejects hidden directories.

The failure is in docs-builder: changelog prepare-artifact uses src/Elastic.Documentation.Tooling/FileSystems/RunnerTempFileSystem.cs, which allowlists only .git. Paths under the checkout that start with . are rejected. .artifacts/... is a descendant of the git root, so it is not added as a disjoint CI root.

Solution

HTML/build filesystems already allow .artifacts. Changelog CI should match that for the conventional CI output dir.

Evaluate already uses version: edge, so a docs-builder GHCR edge publish unblocks consumers without a docs-actions tag.

Implementation details

  • Allowlisted .artifacts on RunnerTempFileSystem and ChangelogFileSystem
  • Added tests/Elastic.Changelog.Tests/Evaluation/ChangelogCiFileSystemTests.cs (allow .artifacts, block .hidden)
  • Added PrepareArtifact_ArtifactsPaths_CopiesYamlAndWritesMetadata prepare-artifact regression test

Block assertions now expect ScopedFileSystemException (not UnauthorizedAccessException).

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable issues found. Verdict: approve.


What is this? | From workflow: PR Review

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant