Allow .artifacts for changelog CI I/O - #3913
Open
lcawl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
No actionable issues found. Verdict: approve.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblock changelog submit by allowlisting
.artifactsin docs-builder’s changelog CI filesystems.Also requires elastic/docs-actions#308
Problem
There are a lot of
changelog-submitfailures since we turned on automatic chagnelog creation in docs-content.They come from docs-actions passing
.artifacts/...paths intodocs-builder changelog prepare-artifact, which usesNullean.ScopedFileSystemand rejects hidden directories.The failure is in docs-builder:
changelog prepare-artifactusessrc/Elastic.Documentation.Tooling/FileSystems/RunnerTempFileSystem.cs, which allowlists only.git. Paths under the checkout that start with.are rejected..artifacts/...is a descendant of the git root, so it is not added as a disjoint CI root.Solution
HTML/build filesystems already allow
.artifacts. Changelog CI should match that for the conventional CI output dir.Evaluate already uses
version: edge, so a docs-builder GHCR edge publish unblocks consumers without a docs-actions tag.Implementation details
.artifactsonRunnerTempFileSystemandChangelogFileSystemtests/Elastic.Changelog.Tests/Evaluation/ChangelogCiFileSystemTests.cs(allow.artifacts, block.hidden)PrepareArtifact_ArtifactsPaths_CopiesYamlAndWritesMetadataprepare-artifact regression testBlock assertions now expect
ScopedFileSystemException(notUnauthorizedAccessException).