Add support for CDN files to the changelog bundle-amend command - #3907
Open
lcawl wants to merge 4 commits into
Open
Add support for CDN files to the changelog bundle-amend command#3907lcawl wants to merge 4 commits into
lcawl wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhance the
--addand--removeoptions in thedocs-builder changelog bundle-amendcommand so they work with files in S3/CDN not just local files.Background
changelog bundlealready treats the CDN as the source of truth for changelog YAML whenbundle.reporesolves.--filesaccepts CDN paths (or any path reduced to a basename) and does not require those files on disk. That matches how teams are expected to work: upload entries, bundle from the pool, then delete local YAML (changelog remove) because bundles are self-contained.changelog bundle-amendnever joined that model.--addand--removecallFile.Existsand read disk only. There is no CDN fetch and no--force-local. The result is a broken post-publish workflow for the common case:file.name. The dummy’s checksum will not match, so you also need--force. That is ceremony, not provenance:--forcealready means “match by name.”--addcannot embed that YAML unless you download it by hand first.bundle --filesalready solves this for new bundles; amend cannot fix a published bundle the same way.Implementation details
changelog bundle-amendnow uses the same CDN vs local sourcing gate aschangelog bundle --files. The changelog-tool skill is unchanged, and nothing was committed.Behavior
bundle.repoor the parent bundle’sreporesolves.--add/--removematch by file name (CDN paths like/changelog/elastic/kibana/main/247279.yamlwork; no local file required).--force-local(andbundle.use_local_changelogs) still reads disk.--force --remove 300.yamlexcludes inferred git-ref entries without a dummy file.CdnChangelogEntryFetcher.FetchNamedAsyncdownloads only the requested names.docs-actions: no
bundle-amendusage; no changes there.Generative AI disclosure
Tool(s) and model(s) used: Cursor Grok 4.6