Add infer option to changelog bundle promotion - #299
Draft
lcawl wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to elastic/docs-builder#3906
Summary
Adds the
--inferfunctionality to the appropriate GitHub Actions. Here's what was done:1.
changelog/bundle-create/action.yml- Addedinferinputinfer(default:'false') with description explaining it enables PR metadata synthesis when no pool file matchesINFERenvironment variable to the validation stepinferis only used withstart-git-ref/end-git-refINFERenvironment variable to both the "Resolve bundle plan" and "Generate changelog bundle" steps[ "$INFER" = "true" ] && ARGS+=(--infer)to both the plan step and the generate step to pass the flag to docs-builder2.
changelog-promotion-bundle.yml- Addedinferinput and forwardinginfer(type: boolean, default: false) with documentationinferparameterbundle-createaction call to forwardinfer: ${{ inputs.infer }}The implementation follows the overall plan:
--prs)infer: truein the action input orbundle.profiles.<name>.infer_missing_changelogs: truein YAMLstart-git-ref/end-git-ref(commit-range bundling)--inferto docs-builder when enabledNOTE: Though no one is using these git-ref-based actions yet, they would nonetheless NOT need to make changes unless they want to opt into the new synthesis functionality.