Modernize crypto, rebuild database setup, and add SQL migrations - #222
Merged
Annotations
21 warnings
|
Complete job
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/setup-dotnet@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Unit + integration tests (Server):
WaveBox.Server/src/ApiHandler/UriWrapper.cs#L107
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
|
|
Unit + integration tests (Server):
WaveBox.Server/src/ApiHandler/UriWrapper.cs#L55
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854)
|
|
Unit + integration tests (Server):
WaveBox.Server/src/WaveBoxMain.cs#L30
Member 'Start' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
Unit + integration tests (Server):
WaveBox.Server/src/WaveBoxMain.cs#L87
Member 'Stop' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
Unit + integration tests (Server):
WaveBox.Server/src/Service/Services/Cron/UserPurge.cs#L21
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
|
|
Unit + integration tests (Server):
WaveBox.Server/src/ServerInfo.cs#L9
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
|
|
Unit + integration tests (Server):
WaveBox.Server/src/ApiHandler/Handlers/TranscodeApiHandler.cs#L68
The variable 'length' is assigned but its value is never used
|
|
Unit + integration tests (Server):
WaveBox.Server/src/ApiHandler/Handlers/TranscodeApiHandler.cs#L65
The variable 'stream' is assigned but its value is never used
|
|
Unit + integration tests (Server):
WaveBox.Server/src/Lastfm.cs#L229
'WebRequest.Create(string)' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
|
|
Unit + integration tests (Server):
WaveBox.Server/src/Lastfm.cs#L204
'WebRequest.Create(string)' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2394
P/Invoke method 'Changes' should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1401)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2391
P/Invoke method 'BusyTimeout' should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1401)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2388
P/Invoke method 'Config' should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1401)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2385
P/Invoke method 'Close' should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1401)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2382
P/Invoke method 'Open16' should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1401)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2379
P/Invoke method 'Open' should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1401)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2375
Specify marshaling for P/Invoke string arguments (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2101)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2375
P/Invoke method 'Open' should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1401)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2372
Specify marshaling for P/Invoke string arguments (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2101)
|
|
Unit tests (Core):
WaveBox.Core/src/SQLiteNet.cs#L2372
P/Invoke method 'Open' should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1401)
|
background
wait
wait-all
cancel
parallel
Loading