Refined Context consume strategy and add UserData and is_consumed to Error structure#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context is now consumed, so the context can't be reused after consumed for some feed failure:
NoAction, since the stack was not modified, the Context still can be reused after failureReduceActionError, since the stack was modified, the Context can't be reused after the error.feedon consumed Context, it will immediately return the error, andcan_feedand it's variant will always return false on consumed Context.accept()now takes&mut selfinstead ofself. Whenacceptsucceeded, the context will be switched into consumed state.