refactor(api): replace unirest with spring restclient and vavr - #11
Merged
Conversation
Replaces the Unirest HTTP client library with Spring's RestClient and introduces Vavr's Either for functional error handling. This change refactors the HttpServiceEngine, all API clients, and updates DTOs and API response handling in listeners. Benefits: - Improves error handling with explicit success/failure states using Either. - Adopts a modern and actively maintained HTTP client. - Enhances consistency and maintainability of API interactions.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Unirest HTTP client library with Spring's RestClient and introduces Vavr's Either for functional error handling. This change refactors the HttpServiceEngine, all API clients, and updates DTOs and API response handling in listeners.
Benefits: