[VSCodeSweeper MVP — test only] Can't hover on top few pixels of editor - #2
[VSCodeSweeper MVP — test only] Can't hover on top few pixels of editor#2egamma wants to merge 1 commit into
Conversation
🤖 copilot /review — round 1VSCodeSweeper MVP self-review (fork-only experiment). ● Get diff stats (shell) ● Get commits on branch (shell) ● Get full diff (shell) Good, the CSS file is present in the
So Now compare to The test itself is essentially just a "canary" test that reads a CSS file and checks it contains a specific string. It's not testing behavior, just verifying file content hasn't regressed. While this is a questionable testing pattern (it's basically a snapshot of one line), the user's question is about bugs and logic errors, not test philosophy. Let me verify the CSS change itself is correct and complete:The CSS fix is correct and straightforward. The No significant issues found in the reviewed changes. The CSS fix is correct — Review SummaryCSS fix ( Test ( No high-confidence bugs or logic errors found. |
|
✅ Round 1: no actionable findings — the review loop converged. |
…st is enabled (microsoft#326086) * Default editor and panel chat to Agent Host Copilot when the agent host is enabled Builds on the chat.editor.preferCopilotHarness behavior to make Agent Host Copilot the computed default chat provider for both editor and panel chat whenever the agent host is enabled, so first-time users land on Copilot instead of Local. chat.editor.preferCopilotHarness stays scoped to the one-time Local -> Copilot migration only. - Thread an agentHostEnabled flag (from IAgentHostEnablementService) through the default-session-type resolution and its callers. - Keep Local visible and selectable; honor explicit and remembered selections. - New Local Chat opens a local session directly: it cancels the in-flight default-provider resolution (which would otherwise block on agent host activation) so the local request wins immediately. - Open a Local chat first in all chat participant API tests, since chat participants are a Local-harness feature. - Add a smoketest.openLocalChat command for Local panel smoke scenarios; the sandbox reopen path reveals the existing local session to avoid a focus race. - Register an IAgentHostEnablementService stub in the component fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: honor resolved session type when starting a new chat Fixes the New Chat drop bug (review comment #2 on microsoft#326086): when the agent host is enabled the computed default is a non-local harness, so the editor clear path recomputed that default and dropped explicit or preserved local requests. - clearChatSessionPreservingType now branches on the resolved session type for the sidebar (non-local -> loadSession, local -> startNewLocalSession) so a generic New Chat from a Local panel preserves Local, consistent with contributed panels. - The resolved type is threaded through IChatWidget.clear -> viewOptions.clear -> chatEditor.clear -> clearChatEditor so the editor opens a session of that type instead of recomputing the default. This restores explicit "New Local Chat" from a non-local editor. - clearChatEditor applies an explicit target type directly and keeps its swap-aware default only for direct (untargeted) calls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: cancel the previous applyModel resolution before replacing it Assigning a new CancellationTokenSource to the MutableDisposable only disposes the previous source, and disposing a CancellationTokenSource does not cancel it. So a re-entrant applyModel() (view render, switch session) left the prior in-flight resolution running, racing to call showModel with a stale result. Cancel the previous source explicitly before replacing it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Upstream issue: microsoft#188878
Change summary
Hovering over text in the top ~6 pixels of the editor viewport is blocked by the scroll-decoration overlay element.
Validation
Open an editor, scroll so the first line is near the top, and verify that hovering over text in the top 6px still triggers the text cursor and editor hover tooltip (not the pointer cursor). Alternatively, add a test verifying the scroll-decoration element has pointer-events: none in its computed style.
Branch
vscodesweeper/fix-188878· generated fix · review loop runs separately (codex review).