Add generic devices to WorkloadStatus#32
Open
clupuishere wants to merge 2 commits into
Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bleggett
reviewed
Jun 10, 2026
| WorkloadMountStatus mount_status = 5; | ||
| google.protobuf.Timestamp created_at = 6; | ||
| WorkloadPciDeviceStatus pci_device_status = 7; | ||
| WorkloadDeviceStatus device_status = 8; |
Collaborator
There was a problem hiding this comment.
How does this conceptually differ from the existing
WorkloadBlockDeviceStatusWorkloadPciDeviceStatusWorkloadMountStatus
?
Do we need all three? If we do, why?
Author
There was a problem hiding this comment.
For the long term, it should replace Workload{Block,Pci}DeviceStatus. Regarding WorkloadMountStatus that's a different (open) discussion given that it's related to filesystems and not to devices.
We are introducing WorkloadDeviceStatus and WorkloadDeviceInfo to define handlers for managing devices in an uniform and generic way. We have been rolling so far with standalone message types for block (WorkloadBlockDeviceInfo message type) and PCI (WorkloadPciDeviceInfo message type) devices and adding support for a new device type (WorkloadFsDeviceInfo message type) raises an immediate need to have a more scalable and generic way of handling devices. Signed-off-by: Costin Lupu <costin@edera.dev>
When sharing host directories, we can either use an unified mount per zone or a mount for each workload. Signed-off-by: Costin Lupu <costin@edera.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current changes are needed to add support for mounts per workload. Since we are introducing a new type of devices, filesystem devices, we need a more generic way of handling devices. With filesystem devices we can share host directories either as unified mounts per zone or as one mount per workload.