mars2grib: fix type of processed data for ssd#232
Open
MircoValentiniECMWF wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts mars2grib’s deduction of GRIB2 typeOfProcessedData so that MARS type=ssd is classified as forecast products rather than processed satellite observations.
Changes:
- Map
mars.type=ssdtoTypeOfProcessedData::ForecastProducts. - Restrict
TypeOfProcessedData::ProcessedSatelliteObservationsmapping tomars.type=gsd.
mars2grib documentation sync (per repo guideline 1000000):
- Impacted files under
src/metkit/mars2grib/**:src/metkit/mars2grib/backend/deductions/typeOfProcessedData.h
- Documentation status: ✅ in sync (Doxygen documentation is co-located in the header; no separate mars2grib docs content describes the specific
ssdmapping that would require updates).
| result = tables::TypeOfProcessedData::AnalysisProducts; | ||
| } | ||
| else if (marsType == "fc") { | ||
| else if (marsType == "fc" || marsType == "ssd" ) { |
| result = tables::TypeOfProcessedData::ControlForecastProducts; | ||
| } | ||
| else if (marsType == "ssd" || marsType == "gsd") { | ||
| else if ( marsType == "gsd") { |
Comment on lines
+159
to
160
| else if (marsType == "fc" || marsType == "ssd" ) { | ||
| result = tables::TypeOfProcessedData::ForecastProducts; |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #232 +/- ##
========================================
Coverage 53.22% 53.22%
========================================
Files 339 339
Lines 14634 14634
Branches 1158 1158
========================================
Hits 7789 7789
Misses 6845 6845 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following: