[ZFDB] feat: Initial version of custom store builder#282
Open
tbkr wants to merge 47 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/zfdb/refactor #282 +/- ##
=========================================================
- Coverage 72.10% 72.08% -0.02%
=========================================================
Files 378 378
Lines 23901 23901
Branches 2504 2504
=========================================================
- Hits 17233 17230 -3
- Misses 6668 6671 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Also removed dead code which triggered an impossible scenario of the bounding box check and therefore caused an underflow in the size_t.
Move internal mappings logic to own subfolder
The fill value in the builder of views is now taken in consideration during the extraction of data from the GRIB messages. If the numerical value of a missing value in the GRIB message is encountered, the value gets replaced by the specified fill_value of the builder.
tbkr
force-pushed
the
feature/zfdb/custom_store_builder
branch
from
July 15, 2026 12:12
26e96b7 to
754024a
Compare
tbkr
force-pushed
the
feature/zfdb/custom_store_builder
branch
from
July 15, 2026 12:22
754024a to
a37dfaa
Compare
The check in ChunkedDataViewImpl for extensionAxisIndex being in bounds was in the wrong position. Moved it in front of the first write access.
Instead of using strings as a representation of the MARS request, use user-defined dictionaries.
tbkr
force-pushed
the
feature/zfdb/refactor
branch
from
July 21, 2026 17:22
cbbb4e3 to
38b3005
Compare
Now we are able to specify arbitrary subgroups and access the data from there.
tbkr
force-pushed
the
feature/zfdb/custom_store_builder
branch
from
July 21, 2026 18:02
a37dfaa to
9d7b9e5
Compare
tbkr
force-pushed
the
feature/zfdb/refactor
branch
4 times, most recently
from
July 23, 2026 13:48
92fa553 to
41278f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now we are able to specify arbitrary subgroups and access the data from there.
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/fdb/pull-requests/PR-282