move to mp4 as new default for videos and fix warning - #2708
Open
iluise wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
eval
clessig
reviewed
Aug 1, 2026
| def _pad_frames_for_mp4(frames: list[np.ndarray], macro_block_size: int = 16) -> list[np.ndarray]: | ||
| """Pad frames to a common size aligned to ``macro_block_size``. | ||
|
|
||
| Frames come from ``savefig(bbox_inches="tight")``, so their pixel dimensions can |
Collaborator
There was a problem hiding this comment.
Wouldn't it be better to fix the dimension when exporting the images with savefig()? Is there a way to retrieve the final size that is/would be obtained with savefig(bbox_inches="tight") and then reuse it. A related concern is that that a slightly changing size will also lead to slightly inconsistent videos.
Collaborator
|
@iluise : can you also fix the linting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix warning with mp4 generation
move to mp4 format as default to avoid weird structures on videos with .gif (which can handle only 256 shades max at a time)
Also, small request: make the colorbars for score plots continuous from blue to red.
Issue Number
Closes #2707
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60