Skip to content

Region-mask the climatology in all scoring pipelines - #2701

Open
wael-mika wants to merge 1 commit into
ecmwf:developfrom
wael-mika:wm/dev/fix_eval
Open

Region-mask the climatology in all scoring pipelines#2701
wael-mika wants to merge 1 commit into
ecmwf:developfrom
wael-mika:wm/dev/fix_eval

Conversation

@wael-mika

Copy link
Copy Markdown
Contributor

Description

Basically what I changed here is applying region sepcific box on climatology so the plots and scores can be calculated with no issues when specifying a region for your evaluation.

I tested it on few runs (imerg and seeps) for 5 regions ['nhem', 'shem', 'tropics', 'europe', 'globa'] and it worked without producing
the alignment error: AlignmentError: cannot align … join='exact' for seeps.

I am not sure if I touched all the needed file and if this fix could lead to an error somewhere else and I would strongly recommend a rigorous review

Issue Number

Closes #2696

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@wael-mika
wael-mika requested a review from iluise July 30, 2026 12:55
@github-actions github-actions Bot added bug Something isn't working eval anything related to the model evaluation pipeline labels Jul 30, 2026

@iluise iluise left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it and it works! I approve it, even if also @jpolz should probably take a look here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working eval anything related to the model evaluation pipeline

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Bug report: Climatology metrics are not region-masked: crash on score maps.

2 participants