Skip to content

[2685] Plot training for LSF - #2695

Draft
pierluigicosi wants to merge 1 commit into
ecmwf:developfrom
pierluigicosi:pierluigicosi/dev/2685_plot_train
Draft

[2685] Plot training for LSF#2695
pierluigicosi wants to merge 1 commit into
ecmwf:developfrom
pierluigicosi:pierluigicosi/dev/2685_plot_train

Conversation

@pierluigicosi

Copy link
Copy Markdown
Contributor

Description

Adds support for LSF alongside Slurm when checking active job runs.

  • Added the LSF command to check active runs

  • Added a check to detect whether the scheduler is Slurm or LSF, so the correct command is used automatically

Issue Number

closes #2685

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@clessig clessig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test so will just approve. But can we move this new code to a separate function It wasn't before but should have been. Good opportunity to clean up.

@clessig

clessig commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

I cannot test so will just approve. But can we move this new code to a separate function It wasn't before but should have been. Good opportunity to clean up.

And please lint and link to the GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Plot training for LSF

2 participants