[rules score] refactor requirements model to use abstract base types#343
Open
AAmbuj wants to merge 1 commit into
Open
[rules score] refactor requirements model to use abstract base types#343AAmbuj wants to merge 1 commit into
AAmbuj wants to merge 1 commit into
Conversation
AAmbuj
requested review from
LittleHuba,
castler,
hoe-jo,
limdor and
ramceb
as code owners
Replace inline union types with abstract base types in the TRLC requirements model for cleaner polymorphism and extensibility: - Add abstract CompReqSource; AssumedSystemReq/FeatReq extend it and CompReqSourceId.item references the base instead of [FeatReq, AssumedSystemReq]. - Add abstract Measure; ControlMeasure/PreventiveMeasure/Mitigation extend it, replacing the tuple Measure union. - Root PreventiveMeasure and Mitigation in RequirementSafety (fixing Mitigation's incorrect AssumedSystemReq parent and PreventiveMeasure having no safety classification). - Drop mitigates from ControlMeasure (tracing is implicit via FTA name-matching); keep mitigates on AoU; give Mitigation an optional rationale. - Add mandatory safety/description/version to the SomePreventiveMeasure test fixture, which the new hierarchy now requires.
AAmbuj
force-pushed
the
amsh_refactor_score_requirements_measure_hierarchy
branch
from
6e58847 to
4323604
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace inline union types with abstract base types in the TRLC requirements model for cleaner polymorphism and extensibility:
Why this change
The bump to TRLC 3.0.0 (commit 08d9163, tag v1.3.0) broke the SCORE requirements model build. TRLC 3.0.0 rejects the bracketed union-list syntax we used for tuple item fields:
A tuple item must be a single type identifier; the [A, B] "any of these" list is not valid TRLC. This caused a cascading failure (unknown symbol CompReqSourceId) and broke downstream targets, e.g.: