Skip to content

Fix FlatBuffers field names to use lowercase snake_case in lm_flatcfg.fbs#290

Merged
NicolasFussberger merged 3 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/flatbuffers-snake-case-field-names
Jul 13, 2026
Merged

Fix FlatBuffers field names to use lowercase snake_case in lm_flatcfg.fbs#290
NicolasFussberger merged 3 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/flatbuffers-snake-case-field-names

Conversation

@shegazyy

@shegazyy shegazyy commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

The FlatBuffers compiler warns when field names do not follow lowercase snake_case convention. Rename all non-conforming fields in lm_flatcfg.fbs (e.g. versionMajor -> version_major, startupConfig -> startup_config). Binary compatibility is preserved because field IDs (id:N) are unchanged.

Update configuration_manager.cpp to use the new generated accessor names, and update the expected JSON output fixtures in the config_mapping tests.

Closes #288

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 76215c44-69c0-4925-8454-0bf52fb12e43
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (31 packages loaded, 10 targets configured)

Analyzing: target //:license-check (80 packages loaded, 10 targets configured)

Analyzing: target //:license-check (143 packages loaded, 723 targets configured)

Analyzing: target //:license-check (152 packages loaded, 4488 targets configured)

Analyzing: target //:license-check (157 packages loaded, 6090 targets configured)

Analyzing: target //:license-check (162 packages loaded, 8243 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9370 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10159 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[16 / 16] no actions running
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.530s, Critical Path: 2.62s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 09:45 — with GitHub Actions Waiting
@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 09:45 — with GitHub Actions Waiting
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 10:50 — with GitHub Actions Waiting
@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 10:50 — with GitHub Actions Waiting
@shegazyy shegazyy force-pushed the fix/flatbuffers-snake-case-field-names branch from 533c77b to f9787cf Compare July 7, 2026 12:08
@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 12:08 — with GitHub Actions Waiting
@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 12:08 — with GitHub Actions Waiting
shegazyy added 2 commits July 8, 2026 15:28
Rename all camelCase/PascalCase field names in lm_flatcfg.fbs to
lowercase_snake_case per FlatBuffers naming conventions.

The binary format is unaffected because field identity is determined
by the id:N attribute, not the field name.

Update all call sites in configuration_manager.cpp to use the new
generated accessor names.

Issue: eclipse-score#288
Replace all old camelCase/PascalCase dict keys in lifecycle_config.py
with the renamed snake_case field names to match the updated schema.

Update the three expected-output lm_demo.json fixture files accordingly
so integration tests continue to pass.

Issue: eclipse-score#288
@shegazyy shegazyy force-pushed the fix/flatbuffers-snake-case-field-names branch from f9787cf to ba39318 Compare July 8, 2026 12:34
@shegazyy shegazyy temporarily deployed to workflow-approval July 8, 2026 12:34 — with GitHub Actions Inactive
@shegazyy shegazyy temporarily deployed to workflow-approval July 8, 2026 12:34 — with GitHub Actions Inactive
@shegazyy

shegazyy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Hey @NEOatNHNG 🙏 ready for review whenever you have a moment!

@NicolasFussberger NicolasFussberger self-requested a review July 13, 2026 06:08
@NicolasFussberger

Copy link
Copy Markdown
Contributor

Hi @shegazyy, thanks for your contribution!
Could you shortly update your branch to the latest main.

@shegazyy shegazyy temporarily deployed to workflow-approval July 13, 2026 10:49 — with GitHub Actions Inactive
@shegazyy shegazyy temporarily deployed to workflow-approval July 13, 2026 10:49 — with GitHub Actions Inactive
@shegazyy

Copy link
Copy Markdown
Contributor Author

@NicolasFussberger branch is updated with the latest main

@NicolasFussberger NicolasFussberger merged commit 8c9580f into eclipse-score:main Jul 13, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Jul 13, 2026
@NicolasFussberger

Copy link
Copy Markdown
Contributor

@shegazyy would you like to do the same fix also for score/launch_manager/src/daemon/src/alive_monitor/config/hm_flatcfg.fbs and score/launch_manager/src/daemon/src/alive_monitor/config/hmcore_flatcfg.fbs ?
Same warnings are coming from these flatbuffer schemas as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Flatbuffers warning about wrong case of field names

2 participants