Launch Manager loads the new configuration file#248
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
Please lnk corresponding issue/bug. |
f13cffe to
eb807a1
Compare
|
The created documentation from the pull request is available at: docu-html |
cd95b35 to
c2e120c
Compare
8219d57 to
e7f13dc
Compare
e7f13dc to
d8e7d9c
Compare
d8e7d9c to
3033564
Compare
3033564 to
70c5a23
Compare
On aarch64, the fd 3 might already be taken up which can result in LaunchManager startup failure
* Add 0.3.0 release notes * Add 0.3.0 release notes * Fix release workflow * Fix review comments * Fix review comments * Update release notes doc id * Update release notes * Fix release notes doc structure * Update relrease notes overview * Add ref to baselibs logging bugfix * Set unique id for every release note file --------- Co-authored-by: Nicolas Fußberger <fun1rlz@bosch.com> Co-authored-by: Nicolas Fußberger <145956508+NicolasFussberger@users.noreply.github.com>
54ca7b5 to
f8e4d73
Compare
| hm_config = ":" + name + "_hm_bin", | ||
| hm_core_config = ":" + name + "_hmcore_bin", | ||
| srcs = select({ | ||
| "//config:lm_use_new_configuration": [":" + name + "_new_lm_bin"], |
There was a problem hiding this comment.
When calling this from another repo (i.e. score_reference_integration) we will need this change to make it work
| "//config:lm_use_new_configuration": [":" + name + "_new_lm_bin"], | |
| Label("//config:lm_use_new_configuration"): [":" + name + "_new_lm_bin"], | |
Additionally, I realize now that we need the feature flag to have public visibility for this to work. Otherwise, reference_integration fails with visibility error
| name = name + "_new_lm_bin", | ||
| data = ":" + new_gen_name, | ||
| schema = new_lm_schema, | ||
| output = name + "_serialized_new/" + config_stem + "_gen.bin", |
There was a problem hiding this comment.
Could we remove the _gen suffix?
Otherwise you will have to know that this is added in order to state this in the "-c " CLI command
Closes: #209