Refactor Compiler Warning Features, Rewire Bazel Usage, and Refresh Module/Docs by AAmbuj · Pull Request #660 · eclipse-score/communication

AAmbuj · 2026-07-07T07:51:01Z

Restructures compiler warning feature management and aligns build/test/docs with the new layout.

Removes obsolete warning-trigger test sources that are no longer part of the supported warning set.
Moves shared compiler warning feature definitions to a common root location for reuse.
Updates Bazel BUILD wiring across warning rules and score targets to use the new feature path.
Adjusts the self-assignment unit test pattern to avoid direct self-assignment while preserving intent.
Refreshes quality documentation and significantly expands warning feature documentation.
Updates module configuration and lockfile to keep dependency/toolchain state consistent.

AAmbuj · 2026-07-07T08:18:52Z

    "conversion": ["-Wfloat-conversion"],
    "shadow": ["-Wshadow"],
    "sign_compare": ["-Wsign-compare"],
-    "unused_parameter": ["-Wunused-parameter"],


removed the unused flag and test cases

AAmbuj · 2026-07-07T08:19:23Z

@@ -1,68 +1,156 @@
-# Compiler Warnings Test


updated the Redmi in more details

AAmbuj · 2026-07-07T08:43:20Z

@@ -100,11 +100,17 @@ score_gcc = use_extension("@score_bazel_cpp_toolchains//extensions:gcc.bzl", "gc
 # score_communication_* cc_features (currently consumed by the LLVM toolchain).
 SCORE_GCC_MINIMAL_WARNING_COMPILE_FLAGS = [


more flags were added there for cross-toolchain parity, not to make warnings stricter than intended

LittleHuba · 2026-07-07T13:50:09Z

 cc_feature(
    name = "minimal_warnings",
    args = [
+        "//quality/compiler_warnings:default_compile_args",


Avoid doing this. This can lead to weird command lines if somebody explicitly enables both features. Instead use implies.

Thanks for the catch. I've updated this to use implies. It cleans up the command-line behavior for concurrent features while keeping the shared flags organized in one place.

LittleHuba · 2026-07-07T13:51:15Z

 cc_feature(
    name = "minimal_warnings",
    args = [
+        "//quality/compiler_warnings:default_compile_args",


AAmbuj · 2026-07-08T09:34:40Z

fix CI PR: #670

LittleHuba · 2026-07-09T08:31:28Z

+cc_feature(
+    name = "minimal_warnings",
+    args = [
+        ":default_compile_args",


This should not be here. You are mixing things.

LittleHuba · 2026-07-09T08:34:29Z

    name = "copyable_atomic_test",
    srcs = ["copyable_atomic_test.cpp"],
-    features = COMPILER_WARNING_FEATURES,
+    features = COMPILER_WARNING_FEATURES + ["-score_communication_treat_warnings_as_errors"],


Please create a follow-up ticket for this or directly a PR to get rid of this again.

I all ready created a fix CI PR: #670: but Jan is saying test itself is a self assign so we cant modify.

LittleHuba · 2026-07-09T08:35:34Z

 llvm.toolchain(
    cxx_standard = {"": "c++17"},
    extra_enabled_features = [
-        "//quality/compiler_warnings:default_flags",


This should stay.
Also ideally move the default flags out of compiler_warnings. They are not about warnings at all. They are the defaults we require to make the compilation sane. Move them to bazel/toolchains/llvm/flags.bzl

…gn test The self-assignment test intentionally triggers -Wself-assign-overloaded, which is promoted to an error by the score_communication_treat_warnings_as_errors feature. Disable this feature for the copyable_atomic_test target so the intentional self-assignment compiles without failing the build.

… warnings

github-project-automation Bot added this to COM - Communication FT Jul 7, 2026

github-project-automation Bot moved this to Backlog in COM - Communication FT Jul 7, 2026

AAmbuj force-pushed the amsh_refactor_gcc_clang_warning_feature branch from 3c6f242 to 987467b Compare July 7, 2026 07:57

AAmbuj self-assigned this Jul 7, 2026

AAmbuj commented Jul 7, 2026

View reviewed changes

Comment thread quality/compiler_warnings/BUILD

AAmbuj commented Jul 7, 2026

View reviewed changes

Comment thread quality/compiler_warnings/BUILD

AAmbuj commented Jul 7, 2026

View reviewed changes

Comment thread quality/quality.md

AAmbuj commented Jul 7, 2026

View reviewed changes

AAmbuj marked this pull request as ready for review July 7, 2026 08:45

AAmbuj requested review from LittleHuba, bemerybmw, castler, crimson11, hoe-jo and limdor as code owners July 7, 2026 08:45

eclipse-score deleted a comment from AAmbuj Jul 7, 2026

AAmbuj force-pushed the amsh_refactor_gcc_clang_warning_feature branch from 987467b to 471ddc6 Compare July 7, 2026 12:36

LittleHuba reviewed Jul 7, 2026

View reviewed changes

AAmbuj force-pushed the amsh_refactor_gcc_clang_warning_feature branch 2 times, most recently from 89c4449 to b13d762 Compare July 8, 2026 09:14

AAmbuj marked this pull request as draft July 8, 2026 09:29

AAmbuj force-pushed the amsh_refactor_gcc_clang_warning_feature branch from 88fa076 to 8e9c001 Compare July 8, 2026 10:02

AAmbuj marked this pull request as ready for review July 9, 2026 06:33

AAmbuj force-pushed the amsh_refactor_gcc_clang_warning_feature branch 3 times, most recently from 8024ed7 to 755ac5c Compare July 9, 2026 07:17

AAmbuj force-pushed the amsh_refactor_gcc_clang_warning_feature branch from 755ac5c to b07f607 Compare July 9, 2026 07:59

LittleHuba reviewed Jul 9, 2026

View reviewed changes

AAmbuj force-pushed the amsh_refactor_gcc_clang_warning_feature branch from b07f607 to 03c8667 Compare July 9, 2026 11:01

AAmbuj added 7 commits July 9, 2026 16:38

test(warnings): remove obsolete warning trigger source files

2997678

refactor(score): move common_features to score root

e49b29a

docs(quality): refresh compiler warning quality references

66d23d8

docs(warnings): expand warning feature and test documentation

6d2ea1c

chore(module): update warning flags and refresh bzlmod lock

5ee44ba

quality (compiler_warnings): split default compile flags from minimal…

aa5e66b

… warnings

AAmbuj force-pushed the amsh_refactor_gcc_clang_warning_feature branch from 03c8667 to aa5e66b Compare July 9, 2026 11:08

		@@ -100,11 +100,17 @@ score_gcc = use_extension("@score_bazel_cpp_toolchains//extensions:gcc.bzl", "gc
		# score_communication_* cc_features (currently consumed by the LLVM toolchain).
		SCORE_GCC_MINIMAL_WARNING_COMPILE_FLAGS = [

Uh oh!

Conversation

AAmbuj commented Jul 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AAmbuj commented Jul 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants